fix: Allow selectedKey=null to clear value in HiddenSelect#8330
Conversation
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Appears to leave behaviour for autofill intact for Dashlane. @yihuiliao can you check with chrome's autofill?
Verified it allows the hidden input to be reset to null as expected
| expect(options.length).toBe(60); | ||
| options.forEach((option, index) => index > 0 && expect(option).toHaveTextContent(states[index - 1].name)); | ||
|
|
||
| fireEvent.input(hiddenSelect, {target: {value: 'CA'}}); |
There was a problem hiding this comment.
just double checking, is this just testing that onSelectionChange isn't called twice? asking because it seems it was passing before the changes in HIddenSelect
| name, | ||
| value: state.selectedKey ?? undefined, | ||
| onChange: (e: React.ChangeEvent<HTMLSelectElement>) => state.setSelectedKey(e.target.value) | ||
| value: state.selectedKey ?? '', |
There was a problem hiding this comment.
This was changed previously in #7670 to fix a different issue. @snowystinger do you remember what was going on there?
There was a problem hiding this comment.
Yep, that was to fix the autocomplete. If I recall correctly, it viewed the '' as a controlled value for the field and wouldn't autofill as a result, React would just overwrite it with the empty string again as there was no onChange event. There is apparently an onInput change for it though, so we can use that to update with the value for auto fill.
There was a problem hiding this comment.
ah, I missed the onInput. Does having both cause setSelectedKey to run twice then?
There was a problem hiding this comment.
good question, i doubt any of our tests check that, so will need to verify
There was a problem hiding this comment.
oh looks like the added test covers it.
3 participants
Closes #8032
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: